Fix global leak typo #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe you meant to have an underscore in front of "key" on line 29. Without that the _key variable used on line 32 leaks into the global namespace.
|
Also, I did run the tape tests, and it passed. |
This was referenced Nov 18, 2014
Closed
Closed
|
+1 for publishing the updated version - thanks! |
|
we need a script that adds all the request org owners to npm for all these modules :) |
|
v0.8.0 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikeal I believe you meant to have an underscore in front of "key" on line 29. If it is not there, the _key variable used on line 32 leaks into the global namespace. Please review and merge.