Add support for PLAINTEXT signature method #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to authenticate to Freshbooks using request, and it turned out that they currently support only
PLAINTEXT
as a signature method http://developers.freshbooks.com/authentication-2/So I read about it here http://oauth.net/core/1.0/#anchor22 and I figured that it should be the same as the
hmacsign
minus the base string.Now obviously the first 3 arguments are not needed in this case, but I kept them here because I just pointed my request's oauth-sign dependency to my patched version and it worked
I can remove these 3 arguments and after this is being published I can patch the request's source code as well, or we can just leave it as it is. Let me know what do you think.
Also summoning @nylen