Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'request' is now deprecated. #57

Closed
shisama opened this issue Feb 13, 2020 · 5 comments · Fixed by #58
Closed

'request' is now deprecated. #57

shisama opened this issue Feb 13, 2020 · 5 comments · Fixed by #58

Comments

@shisama
Copy link
Contributor

shisama commented Feb 13, 2020

request has been deprecated since Feb 11th 2020.
Do you have any plan to deprecate this package?
@analog-nico
Copy link
Member

Yes. Since request-promise-native is just a wrapper around request, it basically has the same fate. Let me know if you have any further questions about it.

@shisama
Copy link
Contributor Author

shisama commented Feb 14, 2020

@analog-nico Thank you for your comment. I think it's better to show this is deprecated on README like 'request'. If you agree withe me, I will send PR.

@analog-nico
Copy link
Member

That would be great. Thank you @shisama !

@shisama shisama mentioned this issue Feb 14, 2020
Merged
@shisama
Copy link
Contributor Author

shisama commented Feb 14, 2020

@analog-nico Thank you. I created the PR(#58).

@analog-nico
Copy link
Member

@shisama Thanks again. Have a great weekend!

shisama added a commit to shisama/request-promise that referenced this issue Feb 15, 2020
@shisama
docs: deprecate this package
052331d 
This package will be deprecated as well as request. Thank you very much for your great works.
'request-promise-native' has already been deprecated.(request/request-promise-native#57)
@shisama shisama mentioned this issue Feb 15, 2020
Merged
shisama added a commit to shisama/request-promise-any that referenced this issue Feb 17, 2020
@shisama
docs: deprecate this package
2d972fa 
This package will be deprecated as well as request. Thank you very much for your great works.
'request-promise-native' has already been deprecated.(request/request-promise-native#57)
@shisama shisama mentioned this issue Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: deprecated as well as request shisama/request-promise-native
2 participants
@analog-nico @shisama