Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: es6+, finally #46

Merged
merged 1 commit into from Aug 6, 2019

Conversation

tbjgolden
Copy link
Contributor

Added docs to clarify two things that nearly made me install request-promise instead of request-promise when I didn't necessarily want to

  1. use ES6+ instead of ES6 as .finally(...) was added in ES9
  2. pointed out that finally(...) is indeed included in Node v10+ native promises

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 239ce46 on tbjgolden:docs/clarify-es6-finally into 2ae195a on request:master.

@rafaeleyng
Copy link

Please accept this, is a simple documentation fix that will avoid a lot of confusion

@analog-nico analog-nico merged commit 171f3b5 into request:master Aug 6, 2019
@analog-nico
Copy link
Member

Thanks a lot @tbjgolden ! And thanks for bumping this up @rafaeleyng !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants