Skip to content

Commit

Permalink
chore: switched to renamed request-promise-core package, version 4.1.1
Browse files Browse the repository at this point in the history
fixes #137, fixes #141
  • Loading branch information
analog-nico committed Aug 8, 2016
1 parent c63e3a3 commit 4ddf490
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ Also check out the new libraries that are **very similar to `request-promise` v4
## Migration from v3 to v4

1. `request` became a peer dependency. Thus make sure that `request` is installed into your project as a direct dependency. (`npm install --save request`)
2. **Note for NPM proxy users:** `request-promise` depends on `@request/promise-core` and downloading such [scoped packages](https://www.npmjs.org/doc/misc/npm-scope.html) seems to be a bit of a challenge for NPM proxies like [`sinopia`](https://github.com/rlidwka/sinopia) or [Artifactory](https://www.jfrog.com/artifactory/). If your `npm install` results in a 404 please read [this issue](https://github.com/request/request-promise/issues/137).
3. Continuation Local Storage is no longer supported. However, you [can get back the support](https://github.com/request/request-promise/wiki/Getting-Back-Support-for-Continuation-Local-Storage) by using `request-promise-any`.
4. When you migrated your `transform` function to v3 and had to add `if (!(/^2/.test('' + response.statusCode))) { return resolveWithFullResponse ? response : body; }` you may now set the option `transform2xxOnly = true` instead.
2. Continuation Local Storage is no longer supported. However, you [can get back the support](https://github.com/request/request-promise/wiki/Getting-Back-Support-for-Continuation-Local-Storage) by using `request-promise-any`.
3. When you migrated your `transform` function to v3 and had to add `if (!(/^2/.test('' + response.statusCode))) { return resolveWithFullResponse ? response : body; }` you may now set the option `transform2xxOnly = true` instead.

## Migration from v2 to v3

Expand All @@ -48,8 +47,6 @@ npm install --save request-promise

`request` is defined as a peer-dependency and thus has to be installed separately.

**Note for NPM proxy users:** `request-promise` depends on `@request/promise-core` and downloading such [scoped packages](https://www.npmjs.org/doc/misc/npm-scope.html) seems to be a bit of a challenge for NPM proxies like [`sinopia`](https://github.com/rlidwka/sinopia) or [Artifactory](https://www.jfrog.com/artifactory/). If your `npm install` results in a 404 please read [this issue](https://github.com/request/request-promise/issues/137).

## Cheat Sheet

``` js
Expand Down Expand Up @@ -578,6 +575,9 @@ If you want to debug a test you should use `gulp test-without-coverage` to run a

## Change History

- v4.1.1 (2016-08-08)
- Renamed internally used package `@request/promise-core` to `request-promise-core` because there where [too](https://github.com/request/request-promise/issues/137) [many](https://github.com/request/request-promise/issues/141) issues with the scoped package name
*(Thanks to @cabrinoob, @crazy4groovy, @dsandor, @KpjComp, @lorenwest, @Reisyukaku, @tehChromic, @todd for providing helpful information.)*
- v4.1.0 (2016-07-30)
- Added cancellation support
*(Thanks to @not-an-aardvark for [pull request #123](https://github.com/request/request-promise/pull/123))*
Expand Down
2 changes: 1 addition & 1 deletion errors.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
'use strict';

module.exports = require('@request/promise-core/errors');
module.exports = require('request-promise-core/errors');
2 changes: 1 addition & 1 deletion lib/rp.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

var Bluebird = require('bluebird').getNewLibraryCopy(),
configure = require('@request/promise-core/configure/request2'),
configure = require('request-promise-core/configure/request2'),
stealthyRequire = require('stealthy-require');

try {
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "request-promise",
"version": "4.1.0",
"version": "4.1.1",
"description": "The simplified HTTP request client 'request' with Promise support. Powered by Bluebird.",
"keywords": [
"xhr",
Expand Down Expand Up @@ -33,7 +33,7 @@
"node": ">=0.10.0"
},
"dependencies": {
"@request/promise-core": "1.1.0",
"request-promise-core": "1.1.1",
"bluebird": "^3.4.1",
"stealthy-require": "^1.0.0"
},
Expand Down

0 comments on commit 4ddf490

Please sign in to comment.