Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for getHeaders removed #1061

Closed
mllrjb opened this issue Sep 9, 2014 · 4 comments
Closed

Support for getHeaders removed #1061

mllrjb opened this issue Sep 9, 2014 · 4 comments

Comments

@mllrjb
Copy link

mllrjb commented Sep 9, 2014

Broken by the fix for #1001

@mikeal
Copy link
Member

mikeal commented Sep 10, 2014

This method should be added to caseless. Once it is we'll update the dep version and push a new release to fix.

@calibr
Copy link
Contributor

calibr commented May 28, 2017

Is this still an issue? I would like to submit a pull request to caseless if it is

@mastermatt
Copy link

I don't see where getHeaders existed before the commit.
setHeaders was removed and instead setHeader, which proxies to caseless.set, can take an object as a single first param with key-value pairs.

Other than that getting all the headers can be done by simply accessing the object at request.headers.

I think this issue should be closed to avoid confusion.

@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 15, 2019
@stale stale bot closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants