Cookie handling kills hand-rolled cookie headers

[timoxley]

Before, we were setting the cookies manually via the header:

request.get({
  url: 'http://someurl.com',
  headers: {
    'Cookie': sessionCookie
  }
}, 

but since the introduction of the built-in cookie handling in request 2.2+, this has broken. I now have to do:

var request = require('request').defaults({jar: false})

…in every file that used the headers mechanism.

Perhaps the cookie system shouldn't override the Cookie header if it already exists?

[mikeal]

yeah, we shouldn't set the cookie header if it's already set.

should be a simple fix.

[mikeal]

this was fixed.

[timoxley]

Really? I ran into this issue again (forgetting .defaults({jar: false}) ) just two days ago.

[mikeal]

a check for headers.cookie was merged in to master a while back, might not be in a release yet. can you test with master?