How to set maxSockets for all requets to be

[ekelvin]

I tried the request.defaults to set hte maxSocket: 3 but the problem still persists, thousands of requests are sent to the server in parallel :S :(.
here is my try, notice download is with callback

request.defaults({ pool: { maxSockets: 3 } });
var download = function (uri, filename, callback) {        
        request.head(uri, function (err, res, body) {
            if (err) {
                console.error(err);
                return;
            }                    
            if (res.headers['content-type'] == "image/jpeg") {
                request(uri).pipe(fs.createWriteStream(filename)).on('close', callback);
            }
            else
                console.error('content-type:' + res.headers['content-type']);
        });        
};

[mikeal]

we need to treat the pool option the same way we do headers, creating a full copy of the underlying option.

[ekelvin]

is there a workaround for this problem?

[FredKSchott]

It seems to be working on my end:

var sharedPool = { maxSockets: 5 };
var req = request.defaults({pool: sharedPool});
var r = req.get('http://google.com', function(err, response) { console.log(r.pool) }); 
// Outputs a pool containing agents with maxSocket = 5
sharedPool.foo = 'bar';
var r = req.get('http://google.com', function(err, response) { console.log(r.pool) }); 
// Outputs a pool containing agents with maxSocket = 5 and with property foo='bar'

The first output tests that maxSockets is properly set. The second tests that all requests are using the same, shared pool so that maxSockets is actually having an effect. (These were all done in the repl with enough time for the first request to come back before firing the second one).

@ekelvin request.defaults() doesn't change the actual request module, it returns a new, wrapped module for you to use. Try this:

var requestWithDefaults = request.defaults({ pool: { maxSockets: 3 } });
// and then...
requestWithDefaults.head(uri, function (err, res, body) {

[nylen]

As @FredKSchott said, do request = request.defaults(...) instead of just request.defaults(...), that seems to be the real issue here.