Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxying requests leaks connections when client timeouts when using the default node v0.10 Agent #1535

Closed
hvrauhal opened this issue Apr 9, 2015 · 2 comments
Closed

Proxying requests leaks connections when client timeouts when using the default node v0.10 Agent #1535

hvrauhal opened this issue Apr 9, 2015 · 2 comments

Comments

@hvrauhal
Copy link

hvrauhal commented Apr 9, 2015

Using the default Agent for proxying requests by piping leaks connections when the clients timeout. Combined with the default outgoing connection pool size of 5 this causes pool exhaustion quickly.

Reproduce with https://github.com/hvrauhal/requestjs-proxy-leaks-agents.
@hvrauhal hvrauhal changed the title Proxying requests leaks connections when client timeouts with the default node v0.10 Agent Proxying requests leaks connections when client timeouts when using the default node v0.10 Agent Apr 9, 2015
hvrauhal added a commit to hvrauhal/requestjs-proxy-leaks-agents that referenced this issue Apr 9, 2015
@hvrauhal
Demonstrate how request proxying breaks the default Agent used by req…
3b9bfe6 
…uestjs when the clients timeout

Reproduces request/request#1535.
@jmandel
Copy link

jmandel commented Jun 29, 2016 •
edited

It looks like from node >= 0.11.0 this is no longer a problem (i.e. the test case no longer reproduces). I think we can close this issue @hvrauhal?

@hvrauhal
Copy link
Author

@jmandel, yes, I hope time and node releases have taken care of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvrauhal @jmandel