-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gzip outgoing request body (POST|PATCH|PUT)? #2397
Comments
Joining this question. I think the "gzip" option relates to the response compression, not to the request compression. It sounds to me like there should be 2 options: "gzip_response" and "gzip_request". There's an issue from 2012 (#234) which was closed, the comments implying that this is now supported? But it's not, right? This left me confused. |
@tzachshabtay: Yes, this confused me too. You are correct. The I'm not sure this module should implement outgoing compression though. I don't believe servers are typically setup to inflate/decompress incoming request bodies. I controlled the server side in my case so I manually decompressed on that end. Saving some bandwidth seemed worth it but it was definitely a custom thing. If I'm wrong and request body compression is expected on the server then I would think this should be implemented. |
What server software are you using? Using NodeJS + Express, and it seems that the server automatically decompressed my manual gzip compressed json body (had to put Content-Encoding=gzip on the request). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue shows how to compress request bodies but I'm wondering why that wouldn't be done automatically with the
{gzip: true}
option?Is this just a technical issue that hasn't been implemented yet?
The text was updated successfully, but these errors were encountered: