Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception thrown when you change encoding and get a non-buffer in the data event #74

Closed
dscape opened this issue Sep 9, 2011 · 2 comments
Closed

Exception thrown when you change encoding and get a non-buffer in the data event #74

dscape opened this issue Sep 9, 2011 · 2 comments

Comments

@dscape
Copy link

dscape commented Sep 9, 2011

@mikeal @isaacs this breaks nano's binary tests - returns an exception

Here is the stack trace plus instructions to reproduce:

https://gist.github.com/ff40d9ce9b73d9394702

Is this my mistake, did some assumption in request changed without me noticing it?

Nuno
@mikeal
Copy link
Member

mikeal commented Feb 18, 2012

this still an issue?

@mikeal mikeal closed this as completed Feb 18, 2012
@dscape
Copy link
Author

dscape commented Feb 18, 2012

Dont think so. I think it got fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes non buffers in data event issue
2 participants
@mikeal @dscape