Moving to module instead of cutomer buffer concatenation. #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If nobody objects in the next 24 hours I'm going to merge this :) |
|
Fixed them thank you |
| i += chunk.length | ||
| }) | ||
| if (buffer.length) { | ||
| debug('has body', self.uri.href) |
There was a problem hiding this comment.
is this debug message correct? (body != uri.href)
There was a problem hiding this comment.
I actually don't know when this originally came from.
There was a problem hiding this comment.
Thank you
On Aug 22, 2014 2:03 AM, "Fred K. Schott" notifications@github.com wrote:
In request.js:
@@ -1015,26 +1017,22 @@ Request.prototype.onResponse = function (response) {
return
}
if (buffer.length && Buffer.isBuffer(buffer[0])) {debug('has body', self.uri.href, bodyLen)var body = new Buffer(bodyLen)var i = 0buffer.forEach(function (chunk) {chunk.copy(body, i, 0, chunk.length)i += chunk.length})if (buffer.length) {debug('has body', self.uri.href)is this debug message correct? (body != uri.href)
Reply to this email directly or view it on GitHub
https://github.com/mikeal/request/pull/1008/files#r16574603.
mikeal
added a commit
that referenced
this pull request
Aug 22, 2014
Moving to module instead of cutomer buffer concatenation.
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Moving to module instead of cutomer buffer concatenation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.