Defaults should not overwrite defined options #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 would love @isaacs to sanity check. |
|
👍 this fixes #1059 as well. |
nylen
added a commit
that referenced
this pull request
Sep 10, 2014
Defaults should not overwrite defined options
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Defaults should not overwrite defined options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent commit, the applying of defaults changed from a
forEachloop that only applied a default if the option isundefined, to using node'sutil._extend, which simply copies from one object to another. This change introduced a regression where defaults overwrite defined options.