Add ability to specifiy querystring lib in options. #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally, I'm good with this change if you add a sentence or two to the readme describing the case where |
|
Ok, updated readme with a section on querystring serialization. |
|
I guess my comment was a little unclear. I don't think this needs a separate section in the readme, rather a short inline description of the problem this option solves is more what I had in mind. Like this: |
Add the ability to specify whether qs or querystring should be used by passing useQs.
jgrund
force-pushed
the
choose-querystring
branch
from
935d9b0
to
77d951b
Compare
|
Ah, I see. Repushed with the inline description. |
|
👍 and thanks for including tests, btw. I'll merge this on Saturday unless someone objects or beats me to it. |
|
Awesome. Thanks much. |
nylen
added a commit
that referenced
this pull request
Oct 11, 2014
Add ability to specifiy querystring lib in options.
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Add ability to specifiy querystring lib in options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify whether qs or querystring should be used for parsing and stringifying by passing a useQuerystring boolean option. Fixes #644.
Has been addressed earlier in #847 and will now merge cleanly.