Support for oauth with RSA-SHA1 signing #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to toehio-feature/oauth_sign_rsa Conflicts: request.js
Also abort all OAuth requests to make this test file complete more quickly.
nylen
changed the title
|
@nylen I looked through your code, it looks good to me, too bad I use another module for signing, but I can actually reconsider this |
|
LGTM |
nylen
added a commit
that referenced
this pull request
Oct 30, 2014
Support for oauth with RSA-SHA1 signing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1042 + tests and docs, and also a change to use the
private_keyOAuth parameter for RSA-SHA1 signing instead of theconsumer_secretparameter which is used for HMAC-SHA1 signing. Per the RFC this is correct.@FredKSchott @mikeal or anyone else: review please? Also, here are a couple of test scripts against http://oauthbin.com/ that give me confidence that this works correctly: https://gist.github.com/nylen/639ef899d9964cb2957c