Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize test ports on 6767 #1337

Merged
merged 1 commit into from Jan 9, 2015

Conversation

Projects
None yet
5 participants
@nylen
Copy link
Member

commented Jan 6, 2015

This is a less commonly used port than 8080 so it is less likely to
conflict with other services. See discussion at #1327.

Standardize test ports on 6767
This is a less commonly used port than 8080 so it is less likely to
conflict with other services.  See discussion at #1327.
@coveralls

This comment has been minimized.

Copy link

commented Jan 6, 2015

Coverage Status

Coverage remained the same when pulling a849e15 on nylen:standardize-test-ports into 3786137 on request:master.

@FredKSchott

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2015

👍
Is there any way to set this globally? It's a shame to define it in so many places if we want to keep it standardized

@nylen

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2015

For the most part, it is standardized (see tests/server.js). Not all test cases use that to create their servers though. The best way to fix it would be to port all of the test cases to use it, but that's more effort than I'm willing to undertake now.

We could also add a tests/vars.js or similar, but is it really worth adding an extra require in all of these files just to store one number?

@simov

This comment has been minimized.

Copy link
Member

commented Jan 7, 2015

On the other hand the unit tests should be as self contained as possible, unless you really have to copy paste huge amount of similar code in each file. I think the port number is not a big problem as it can be fixed with simple find and replace.

@FredKSchott

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2015

👍 Sounds good :)

@mikeal

This comment has been minimized.

Copy link
Member

commented Jan 7, 2015

ideally it could be parametrized so that test could be run in parallel.

@nylen

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2015

Sounds tricky. Switching to the new Travis docker infrastructure helped build times a lot.

Are we good to merge this? I'll do it tomorrow if no one objects or beats me to it.

nylen added a commit that referenced this pull request Jan 9, 2015

Merge pull request #1337 from nylen/standardize-test-ports
Standardize test ports on 6767

@nylen nylen merged commit 2100b49 into request:master Jan 9, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.