Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node.js 0.12 and io.js to travis.yml #1415

Merged
merged 1 commit into from Mar 5, 2015
Merged

Conversation

desenmeng
Copy link
Contributor

No description provided.

@simov
Copy link
Member

simov commented Feb 8, 2015

Apparently it won't be as straightforward as this.

@FredKSchott
Copy link
Contributor

A lot of request logic was changed during the last two years in v0.11, I'm not suprised :/

@nickmccurdy
Copy link
Contributor

Node 0.12/io.js support seems like it's both important to this project and at high demand. I think it would benefit this project to merge this pull request into a branch that would then be used for 0.12 and io.js development (so everyone can test against 0.12 and io.js in CI without breaking master's build).

@nickmccurdy
Copy link
Contributor

By the way, does anyone know if it's possible to allow failures for specific Node versions on Travis? It has something like that for environment variables, but if we can figure out a way to get this to work for Node versions we can show 0.12 and io.js results in CI but prevent the build from being marked as failing while the fixes are in development.

@nickmccurdy
Copy link
Contributor

To answer my own question, yes, it is possible to allow failures on specific versions of Node. I have created a pull request similar to yours, but with allowed failures: #1453.

@simov simov merged commit d7ed0a5 into request:master Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants