Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix cookie and redirect bugs and add auth support for HTTPS tunnel #203

Merged
merged 5 commits into from

3 participants

@milewise

Fixed: The proxy.auth option wasn't being passed through to the https tunnel. This prevented the https tunnel from being used with proxy servers that require authentication.

Fixed: Due to a bug in the composable jar code, cookies weren't being set properly in redirects.

Fixed: Cookie attributes should be case insensitive. For example, the cookie parser fails when Path=/ is used instead of path=/

Fixed: When following non-GET redirects, remove any content in the body of the request. Otherwise, servers will complain about the GET request being malformed.

@mikeal
Owner

would appreciate a node on this one from @isaacs

@isaacs

LGTM. Doesn't appear to break npm. It would be nice if there was a test for the basic auth HTTPS tunneling.

@mikeal mikeal merged commit 7184e8c into from
@cybdoom cybdoom referenced this pull request from a commit in cybdoom/EbayAmazonApiServer
@cybdoom cybdoom