Fix cookie and redirect bugs and add auth support for HTTPS tunnel #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would appreciate a node on this one from @isaacs |
|
LGTM. Doesn't appear to break npm. It would be nice if there was a test for the basic auth HTTPS tunneling. |
mikeal
added a commit
that referenced
this pull request
Mar 14, 2012
Fix cookie and redirect bugs and add auth support for HTTPS tunnel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: The
proxy.authoption wasn't being passed through to the https tunnel. This prevented the https tunnel from being used with proxy servers that require authentication.Fixed: Due to a bug in the composable jar code, cookies weren't being set properly in redirects.
Fixed: Cookie attributes should be case insensitive. For example, the cookie parser fails when
Path=/is used instead ofpath=/Fixed: When following non-GET redirects, remove any content in the body of the request. Otherwise, servers will complain about the GET request being malformed.