Aws sign4 #2031
Closed
Aws sign4 #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simov any news about the merge? |
|
I'll take a look at it shortly. In the meantime can you squash all commits into one, I really don't want to merge commits like fix, fix, fix - 'Added aws-sign4 support' should be just enough |
added aws-sign4 support added tests Added sign_version parameter doc fixed test fix changes removed changes on CHANGELOG fix fix fix comma
|
Ok makes sense. done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2029
Applied changes in order to use aAWS sign version 4