need to use Authorization (titlecase) header with Tumblr OAuth #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
making the header case sensitive violates the spec, so that pisses me off. fucking tumblr. |
mikeal
added a commit
that referenced
this pull request
Mar 27, 2012
need to use Authorization (titlecase) header with Tumblr OAuth
|
yeah, I agree. I'd actually prefer to keep it lowercase inside of request up until the end (otherwise there will be bugs against both 'authorization' and 'Authorization' headers soon), but didn't see an easy way to do that. |
|
damn you, you've guilt-tripped me (by merging this pull request in) to do this better. I will be back with a mo' better version. |
|
yegh, after writing the alternative I decided this minimal change was probably better. let me know if you prefer one over the other though. I'm instead going to use my time to try to get tumblr to allow case-insensitive headers. |
|
whoo hoo!! tumblr is case-insensitivizing their header requirements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran into this with the tumblr oauth implementation in particular. it seems way strict. it requires
Authorization:as the header and not justauthorization:. I'm not sure if any other oauth providers break on this or not.not sure what the policy is on lowercase vs. titlecase headers though. my change seems quite arbitrary and confusing unless it's somehow applied to all headers or made case-insensitively somehow.
any guidance?