need to use Authorization (titlecase) header with Tumblr OAuth #217

Merged
merged 1 commit into from Mar 27, 2012

Projects

None yet

2 participants

@visnup
Contributor
visnup commented Mar 27, 2012

ran into this with the tumblr oauth implementation in particular. it seems way strict. it requires Authorization: as the header and not just authorization:. I'm not sure if any other oauth providers break on this or not.

not sure what the policy is on lowercase vs. titlecase headers though. my change seems quite arbitrary and confusing unless it's somehow applied to all headers or made case-insensitively somehow.

any guidance?

@mikeal
Member
mikeal commented Mar 27, 2012

making the header case sensitive violates the spec, so that pisses me off.

fucking tumblr.

@mikeal mikeal merged commit 7fff74c into request:master Mar 27, 2012
@visnup
Contributor
visnup commented Mar 27, 2012

yeah, I agree. I'd actually prefer to keep it lowercase inside of request up until the end (otherwise there will be bugs against both 'authorization' and 'Authorization' headers soon), but didn't see an easy way to do that.

@visnup
Contributor
visnup commented Mar 27, 2012

damn you, you've guilt-tripped me (by merging this pull request in) to do this better. I will be back with a mo' better version.

@visnup
Contributor
visnup commented Mar 27, 2012

yegh, after writing the alternative I decided this minimal change was probably better. let me know if you prefer one over the other though.

I'm instead going to use my time to try to get tumblr to allow case-insensitive headers.

@visnup
Contributor
visnup commented Mar 28, 2012

whoo hoo!! tumblr is case-insensitivizing their header requirements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment