Documentation: Added Simple JSON Example with oAuth #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a common enough example to warrant it own example. This assumes you are doing oAuth with your known token/keys (connecting to your own app). Not sure the best way to word the difference between that and your other example...
Huachao
reviewed
Mar 30, 2017
README.md
Outdated
| @@ -27,6 +27,7 @@ request('http://www.google.com', function (error, response, body) { | |||
|
|
|||
| ## Table of contents | |||
|
|
|||
| - [Simple JSON with oAuth](#simple-json-with-oauth) | |||
There was a problem hiding this comment.
I think OAuth is more general than oAuth
Huachao
reviewed
Mar 30, 2017
README.md
Outdated
| } | ||
| }, | ||
| function (error, response, body) { | ||
| if (!error && response.statusCode == 200) { |
Huachao
reviewed
Mar 30, 2017
README.md
Outdated
| console.log(body); //handle success | ||
| } | ||
| else { | ||
| console.log("Error "+response.statusCode); //handle error |
There was a problem hiding this comment.
add space before and after '+'
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
reconbot
reviewed
Nov 23, 2018
Co-authored-by: Francis Gulotta <wizard@roborooter.com>
|
Don't know if this is still relevant/accurate but just noticed the comments so updated in case it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a common enough scenario to warrant it own example. This assumes you are doing oAuth with your known token/keys (connecting to your own app). Not sure the best way to word the difference between that and your other example...
PR Checklist:
npm testlocally and all tests are passing.PR Description