Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled '"toString()" failed' uncaught error. #2903

Closed
wants to merge 2 commits into from

Conversation

aniltallam
Copy link

@aniltallam aniltallam commented Apr 3, 2018

Fix for the issue - #2067

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
    test case was not added because, huge files (>256mb) should be used for testing. attaching this file to the project will drastically increases the repo size.

PR Description

For response size >256mb, buffer.toString throws an error (nodejs/node#3175). Since this was thrown in end event handler, there is no way for the developers to catch these exceptions, so it is resulting in uncaught Errors/Exceptions.

So we have to gracefully handle those scenarios by catching those errors and then emitting error event.

@raaaaaaaaaan
Copy link

You may can try to upgrade to Node 10.0.0 to catch the error
#2826 (comment)

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@stale stale bot closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants