Handled '"toString()" failed' uncaught error. #2903
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue - #2067
PR Checklist:
npm test
locally and all tests are passing.test case was not added because, huge files (>256mb) should be used for testing. attaching this file to the project will drastically increases the repo size.
PR Description
For response size >256mb, buffer.toString throws an error (nodejs/node#3175). Since this was thrown in end event handler, there is no way for the developers to catch these exceptions, so it is resulting in uncaught Errors/Exceptions.
So we have to gracefully handle those scenarios by catching those errors and then emitting error event.