fix: error on Querystring.prototype.rfc3986 when the 'str' parameter is not a string #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
I have run
npm testlocally and all tests are passing.Yes, I've run it but some test were not passing even before I made any edits, please check it.
I have added/updated tests for any new behavior.
I don't think any test should be added/updated, again, please check.
If this is a significant change, an issue has already been created where the problem/solution was discussed: str.replace is not a function request-promise#134
PR Description
I was using request-promise (https://www.npmjs.com/package/request-promise) when I got the error that says: 'str.replace is not a function' then I changed the code in the node_modules (just like what I did in this PR) and I no longer get the error. I'm a newbie developer so please do check my code, it's just one line but I'll be really happy to contribute what I can and if it turns out that my code is not working as you expected, please do tell me about it. Thank you very much, have a nice day!