Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SSL negotiation timings in timings and timingPhases objects #3128

Closed
wants to merge 3 commits into from
Closed

Include SSL negotiation timings in timings and timingPhases objects #3128

wants to merge 3 commits into from

Conversation

jschoudt
Copy link

PR Checklist:

PR Description

This adds secureConnect to the timings object and ssl to the timingPhases object when you specify time: true in the request options.

@codenirvana
Copy link

@jschoudt Great work!
One nitpick, on secureConnect the firstByte phase will changes to:
response.timingPhases.firstByte = self.timings.response - self.timings.secureConnect

Added this to our fork last month: postmanlabs#33 😅
I don't feel this project is actively maintained, otherwise we are happy to sync all the feature/fixes we are doing in our fork.

@jschoudt
Copy link
Author

@codenirvana Thanks for the review. And yeah, I see that the PRs are a bit backed up here. I'll fix that issue you pointed out. I did this because I want this capability upstream here: artilleryio/artillery#665 so I guess I'll be stuck forking and building a custom npm until this PR gets merged. Not complaining, I get that this is no one's day job 8)

@stale
Copy link

stale bot commented Mar 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 13, 2020
@stale stale bot closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants