-- upgrade dependencies #3425
Open
-- upgrade dependencies #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserAdminD3us
approved these changes
Aug 30, 2022
rtharston
suggested changes
Sep 28, 2023
There was a problem hiding this comment.
The title of the PR says you upgraded the dependencies, but this includes a lot of other changes. Please only update the dependencies and revert the rest.
Updating var to const where possible isn't a bad thing, but is not within the scope of your stated change.
| @@ -443,7 +443,7 @@ | |||
| - [#1116](https://github.com/request/request/pull/1116) Fix typo in `noProxyHost` definition (@FredKSchott) | |||
| - [#1114](https://github.com/request/request/pull/1114) linting fix: Added a `new` operator that was missing when creating and throwing a new error (@FredKSchott) | |||
| - [#1096](https://github.com/request/request/pull/1096) No_proxy support (@samcday) | |||
| - [#1107](https://github.com/request/request/pull/1107) linting-fix: remove unused variables (@FredKSchott) | |||
| - [#1107](https://github.com/request/request/pull/1107) linting-fix: remove unused letiables (@FredKSchott) | |||
There was a problem hiding this comment.
It looks like you performed a search replace on var with let, and it went a bit too far afield.
There are quite a few of these in the changelog and readme, and probably other places too, they'll need changed back.
| @@ -125,7 +125,7 @@ request.defaults = function (options, requester) { | |||
| } | |||
|
|
|||
| request.forever = function (agentOptions, optionsArg) { | |||
| var options = {} | |||
| const options = {} | |||
There was a problem hiding this comment.
What do all these var to const replacements have to do with upgrading dependencies?
Did you run a linter or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm testlocally and all tests are passing.PR Description