Delete self._form along with everything else on redirect #360

Merged
merged 1 commit into from Nov 1, 2012

Projects

None yet

2 participants

@jgautier
Contributor
jgautier commented Nov 1, 2012

When posting a file to a url that does a redirect I was getting this error from request:

You have already piped to this stream. Pipeing twice is likely to break the request.

The post callback would never get fired. When I deleted self._form it fixed the issue and I think it makes sense since its already deleting self.body etc.

@mikeal mikeal merged commit 9a3129c into request:master Nov 1, 2012
@mikeal
Member
mikeal commented Nov 1, 2012

redirects on PUT/POST really suck. i think we can make these work better once read() streams are in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment