Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.10 compat #473

Merged
merged 2 commits into from
Mar 13, 2013
Merged

V0.10 compat #473

merged 2 commits into from
Mar 13, 2013

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Mar 13, 2013

Note the last bullet in the tl;dr section on the streams2 blog post.

This makes sure that doesn't ever happen. All tests pass on v0.10.0.

Also in this pull req, is support for setting NODE_DEBUG=request and getting a bunch of debugging output. I figured since I could not have tracked down the problem without that, it was probably worth leaving in. (We use that env in core for this purpose.)

Used the same kind of debugging technique that's all throughout core.

It's fast, nodey, and extremely useful when tracking down bugs.

The next commit will fix the bugs I tracked down using this method.
Note: Request is *not*, at this point, presenting a streams2
API.  However, with this patch, it does not leave responses in
a paused state indefinitely, by taking care to consume every
request that it receives.
mikeal added a commit that referenced this pull request Mar 13, 2013
@mikeal mikeal merged commit 9e54bdd into request:master Mar 13, 2013
@isaacs isaacs deleted the v0.10-compat branch March 13, 2013 15:58
@isaacs isaacs restored the v0.10-compat branch September 3, 2014 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants