V0.10 compat #473

merged 2 commits into from Mar 13, 2013


None yet

2 participants

isaacs commented Mar 13, 2013

Note the last bullet in the tl;dr section on the streams2 blog post.

This makes sure that doesn't ever happen. All tests pass on v0.10.0.

Also in this pull req, is support for setting NODE_DEBUG=request and getting a bunch of debugging output. I figured since I could not have tracked down the problem without that, it was probably worth leaving in. (We use that env in core for this purpose.)

isaacs added some commits Mar 13, 2013
@isaacs isaacs Print debug logs NODE_DEBUG=request in environment
Used the same kind of debugging technique that's all throughout core.

It's fast, nodey, and extremely useful when tracking down bugs.

The next commit will fix the bugs I tracked down using this method.
@isaacs isaacs Flow data in v0.10-style streams
Note: Request is *not*, at this point, presenting a streams2
API.  However, with this patch, it does not leave responses in
a paused state indefinitely, by taking care to consume every
request that it receives.
@mikeal mikeal merged commit 9e54bdd into request:master Mar 13, 2013
@isaacs isaacs deleted the isaacs:v0.10-compat branch Mar 13, 2013
@isaacs isaacs restored the isaacs:v0.10-compat branch Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment