V0.10 compat #473
Merged
V0.10 compat #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the same kind of debugging technique that's all throughout core. It's fast, nodey, and extremely useful when tracking down bugs. The next commit will fix the bugs I tracked down using this method.
Note: Request is *not*, at this point, presenting a streams2 API. However, with this patch, it does not leave responses in a paused state indefinitely, by taking care to consume every request that it receives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the last bullet in the tl;dr section on the streams2 blog post.
This makes sure that doesn't ever happen. All tests pass on v0.10.0.
Also in this pull req, is support for setting
NODE_DEBUG=requestand getting a bunch of debugging output. I figured since I could not have tracked down the problem without that, it was probably worth leaving in. (We use that env in core for this purpose.)