Do not overwrite established content-type headers for read stream deliver #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -327,7 +327,8 @@ Request.prototype.request = function () { | |||
| if (options.ntick) throw new Error("You cannot pipe to this stream after the first nextTick() after creation of the request stream.") | |||
| options.src = src | |||
| if (isReadStream(src)) { | |||
| options.headers['content-type'] = mimetypes.lookup(src.path.slice(src.path.lastIndexOf('.')+1)) | |||
| if (!options.headers['content-type'] && !options.headers['Content-Type']) | |||
There was a problem hiding this comment.
it really sucks that we have to do this case lookup. i should put in a ticket to core about making this less annoying.
mikeal
added a commit
that referenced
this pull request
Aug 22, 2011
Do not overwrite established content-type headers for read stream deliver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not overwrite established content-type headers for read stream deliveries. Affects any and all upper libraries (e.g. cloudfiles)