change cookie module,to tough-cookie.please check it . #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change cookie module cookie-jar to tough-cookie.because cookie-jar has some bug
mikeal
added a commit
that referenced
this pull request
Oct 3, 2013
change cookie module,to tough-cookie.please check it .
|
I'm merging this in to master but i expect that some of the external API changes are going to cause breakage that we'll need to fix before a release goes out. |
|
yes. it need doing more tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #672 ,you let me do some change .and i have finished it.
all tests passed but #304 ( not because of my code).
so please check the code .
#672