Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about JSON output body type #742

Merged
merged 1 commit into from Dec 23, 2013

Conversation

Projects
None yet
3 participants
@iansltx
Copy link
Contributor

commented Dec 23, 2013

When PUTing/POSTing JSON using the json option, you might overlook the fact that Request will automatically parse the response as JSON before handing it back to the callback, thus causing confusion and heartbreak. Probably best to mention this behavior in all applicable places.

mikeal added a commit that referenced this pull request Dec 23, 2013

Merge pull request #742 from iansltx/master
Add note about JSON output body type

@mikeal mikeal merged commit d98c94d into request:master Dec 23, 2013

1 check passed

default The Travis CI build passed
Details
@cerebrl

This comment has been minimized.

Copy link

commented Dec 23, 2013

Thanks @mikeal and @iansltx! Hopefully this will save someone from the frustration I had O_o

nylen pushed a commit to nylen/request that referenced this pull request Oct 17, 2014

Merge pull request request#742 from iansltx/master
Add note about JSON output body type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.