Can't post binary to multipart requests #86

Merged
merged 1 commit into from Nov 18, 2011

Projects

None yet

3 participants

@kkaefer
Contributor
kkaefer commented Oct 4, 2011

request tries to concatenate text to the body part of a multipart request, which stringifies the buffer object. Instead, it should write the buffer to the socket as is.

@kkaefer
Contributor
kkaefer commented Oct 5, 2011

(This is required to send multipart files to S3, as Amazon doesn't seem to accept base64 encoded files despite a Content-Transfer-Encoding header)

@kkaefer
Contributor
kkaefer commented Oct 14, 2011

Would love to deploy this pretty soon. What's in the way to getting this merged?

@mikeal
Member
mikeal commented Oct 26, 2011

this looks great but i'd really like a test for it.

if you don't write one in the next few days then i probably will.

@joemccann
Contributor

Any news on this?

@mikeal
Member
mikeal commented Nov 18, 2011

i'm going to merge it, hopefully someone will write a test or tell me if it's broken, but it's better than not having it.

@mikeal mikeal merged commit 00be754 into request:master Nov 18, 2011
@joemccann
Contributor

agreed.

@mikeal
Member
mikeal commented Nov 18, 2011

also, i won't push a new release to npm until someone verifies that this works and doesn't break the old API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment