Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Can't post binary to multipart requests #86

Merged
merged 1 commit into from

3 participants

@kkaefer

request tries to concatenate text to the body part of a multipart request, which stringifies the buffer object. Instead, it should write the buffer to the socket as is.

@kkaefer

(This is required to send multipart files to S3, as Amazon doesn't seem to accept base64 encoded files despite a Content-Transfer-Encoding header)

@kkaefer

Would love to deploy this pretty soon. What's in the way to getting this merged?

@mikeal
Owner

this looks great but i'd really like a test for it.

if you don't write one in the next few days then i probably will.

@joemccann

Any news on this?

@mikeal
Owner

i'm going to merge it, hopefully someone will write a test or tell me if it's broken, but it's better than not having it.

@mikeal mikeal merged commit 00be754 into from
@joemccann

agreed.

@mikeal
Owner

also, i won't push a new release to npm until someone verifies that this works and doesn't break the old API.

@cybdoom cybdoom referenced this pull request from a commit in cybdoom/EbayAmazonApiServer
@cybdoom cybdoom