Destroy socket on unsuccessful CONNECT #46
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the proxy server replies with
statusCode !== 200
to theCONNECT
request the socket is left half open and sits inCLOSE_WAIT
state until the process quits.This change makes sure sockets are destroyed when the proxy server is unable to establish a connection with the upstream server.
Here's a simple test to illustrate the problem:
Running from request/tunnel-agent:
Running from alltherooms/tunnel-agent: