NewsFox: redirected feeds blocked and not saved

[msxfm]

Issue by jsamuel
Thursday Dec 22, 2011 at 18:46 GMT
Originally opened as RequestPolicy/requestpolicy#18

---

imported trac ticket
created: 2009-06-21 17:59:42
reporter: justin

Cross-site redirected feeds are not only blocked but may not even be retained by !NewsFox if it cannot retrieve them. Additionally, some content (e.g. images) of feeds is blocked because the requests have the origin of "about:blank".

[msxfm]

Comment by jsamuel
Thursday Dec 22, 2011 at 18:46 GMT

---

imported trac comment
created: 2009-06-21 18:00:47
author: justin

Currently !RequestPolicy detects the presence of !NewsFox and adds a conflict warning in the menu.

[msxfm]

Comment by jsamuel
Thursday Dec 22, 2011 at 18:46 GMT

---

imported trac comment
created: 2009-06-21 21:38:56
author: justin

Brian Piper mentioned the following by email:

I am a !NewsFox user and the conflict between the two is a problem. I have read the "Conflicts with other extensions" section on your website and the Workaround suggested seems inadequate; white listing every single feed is only feasible if you have a small number of feeds. I would like to make a few suggestions/comments.

1. in the Request Log the Origin is listed as about:blank. I tried white listing this but it did not work. It would be nice if this worked, however, about:blank may be too broad an exception.

2. the context menu in the statusbar provides options to allow and temporarily allow all requests from !NewsFox. It is very annoying to be provided with an option that does not work. If these functions are not available then perhaps you should disable these items.

3. If white listing every single feed is the only solution then it would be very convenient if a context menu was provided in the Request Log to add the selection to the Destinations white list or at the very least to copy the url to the clipboard.

[msxfm]

Comment by ghost
Wednesday Mar 28, 2012 at 04:04 GMT

---

Hi, i too am using request policy and newsfox.

Some feeds such as google news and feedburner give Moved temporarily and i have to manually allow each of those requests.

Also, some youtube feeds don't show images.

I tried allowing the destination gdata.youtube.com, as that's where the images come from, but it doesn't work.

So, have you found some solution to the conflict?

EDIT: I solved the youtube images issue by allowing destination ytimg.com (it wasn't gdata.youtube.com). But the redirecting feeds problem still remains.

[nodiscc]

Can anyone reproduce this bug? If no info is preovided in the following month (up to 24 Jan 2015), I will close this issue as it has not been touched for 2.5 years.

[myrdd]

This issue mentions multiple bugs, which are partially fixed.

For the bugs mentioned by Brian Piper I'll create a new gh-issue. [Edit] see #707.

feed.rss redirection

Summary: this bug seems to be fixed by another bug. Fixing the secondary bug will cause the *.rss redirection bug to re-appear. What has to be done needs to be investigated.

This *.rss redirection bug is what has been mentioned earlier:

• by jsamuel: Cross-site redirected feeds are not only blocked but may not even be retained by !NewsFox if it cannot retrieve them.
• by ghost: Some feeds such as google news and feedburner give Moved temporarily and i have to manually allow each of those requests. (…) EDIT: (…) But the redirecting feeds problem still remains.

They talk about the case the URL of a *.rss file redirects to another URL with different host. The bug is currently fixed but there's an issue. The following log entries appear when such a RSS file is added as a new feed to NewsFox:

[RequestPolicy] [WARNING] [HEADER_REDIRECT] The redirection's Load Context couldn't be found! TypeError: this.httpChannel.loadGroup is null
[RequestPolicy] [WARNING] [HEADER_REDIRECT] ** ALLOWED ** 'Location' header to <http://www.otherdomain.test/feed_1.rss> from <http://www.maindomain.test/redirect-http-location-header.php?path=feed_1.rss>. Original request is from privileged code.

There's the code

if (!isContentRequest(httpResponse)) {
  // ...
}

which leads to the ** ALLOWED ** 'Location' header … log message. However, in this case isContentRequest() returns null because the Load Context couldn't be found. Therefore I think the code should be as follows:

if (isContentRequest(httpResponse) === false) {
  // ...
}

However, this would break NewsFox. I need to check what needs to be done.

blocked images

I did not investigate this issue, but according to ghost it's fixed or hasn't been an issue. This is what has been said:

• by jsamuel: Additionally, some content (e.g. images) of feeds is blocked because the requests have the origin of "about:blank".
• by ghost: some youtube feeds don't show images. I tried allowing the destination gdata.youtube.com, as that's where the images come from, but it doesn't work. (…) EDIT: I solved the youtube images issue by allowing destination ytimg.com (it wasn't gdata.youtube.com).