Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't change color of "RequestPolicy" label in context menu #31

Closed
msxfm opened this issue Jul 7, 2014 · 2 comments
Closed

don't change color of "RequestPolicy" label in context menu #31

msxfm opened this issue Jul 7, 2014 · 2 comments
Labels
good first issue subtype: user experience
Milestone
1.0.beta13.0

Comments

@msxfm
Copy link

msxfm commented Jul 7, 2014

Issue by jsamuel
Thursday Dec 22, 2011 at 18:47 GMT
Originally opened as RequestPolicy/requestpolicy#31

imported trac ticket
created: 2009-08-12 09:17:05
reporter: justin

In the context menu, the label that says "RequestPolicy" changes color to match the flag icon next to it. Adam mentioned that this can be distracting and so not good for overall usability. I tend to agree. The color of the text in the label should stay black.
@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by jsamuel
Thursday Dec 22, 2011 at 18:47 GMT

imported trac comment
created: 2010-05-02 18:15:54
author: eibwen

Is this still valid?

Current version seems to have the icon and the text label mutually exclusive. As such, changing color would seem to be a good thing, excepting possible accessibility concerns.

@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by gsomgsomgsom
Friday Jul 04, 2014 at 18:38 GMT

3

Hello! This issue seems to be still valid with firefox with dark theme. RequestPolicy and all blocked site sites are unreadable. Please make RequestPolicy use system colors like other extensions. I try to attach screenshot of my request policy context menu,

@myrdd myrdd added the design label Dec 2, 2014
@myrdd myrdd added this to the 1.0 milestone Dec 2, 2014
@myrdd myrdd removed this from the 1.0 milestone Aug 13, 2016
@myrdd myrdd added this to the 1.0.beta13.0 milestone Aug 13, 2016
@myrdd myrdd closed this as completed in 04156f8 Aug 13, 2016
jrrdev pushed a commit to jrrdev/requestpolicy that referenced this issue Nov 22, 2017
@myrdd
[fix] context menu: don't change font color
1ec8c87 
For better usability, the font color of RP's context menu entry
should be independent of the flag color. Fixes RequestPolicyContinued#31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue subtype: user experience
Projects
None yet
Milestone
1.0.beta13.0
Development

No branches or pull requests
2 participants
@myrdd @msxfm