Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] infrequently paths showing as allowed destination hosts in menu #39

Closed
msxfm opened this issue Jul 7, 2014 · 1 comment
Closed

Comments

@msxfm
Copy link

msxfm commented Jul 7, 2014

Issue by jsamuel
Thursday Dec 22, 2011 at 18:47 GMT
Originally opened as RequestPolicy/requestpolicy#39


imported trac ticket
created: 2009-09-17 16:49:27
reporter: justin

Sometimes a path will show up as an allowed destination hostname in the menu. I finally found a repeatable (for the moment) example of this happening and it appears to be with a 303 Object Moved redirect to a location that is just a path (no protocol + host).

Example with some specifics removed (so you don't know what coupon my wife wanted me to print):

http://coupons2.smartsource.com/smartsource/index.jsp?Link=XXXXXXX

elicited the following Location header in the response:

Location: /YYYYYYY/dcs.gif?dcsredirect=126&dcstlh=0&...

which appears to match what I see in the !RequestPolicy menu.

However, it seems like there must be more to it as one would think this would be fairly common and so the bug would have been visible more frequently. I'll need to come up with a repeatable test case to be sure that this is the issue.

@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by jsamuel
Thursday Dec 22, 2011 at 18:47 GMT


imported trac comment
created: 2009-09-20 16:00:24
author: justin

Fixed in r274. This turned out to be caused by not correctly handling redirect destination locations that were only paths, not valid URIs.

@msxfm msxfm closed this as completed Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant