Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] All accesses from/to ip address are blocked #49

Closed
msxfm opened this issue Jul 7, 2014 · 2 comments
Closed

[CLOSED] All accesses from/to ip address are blocked #49

msxfm opened this issue Jul 7, 2014 · 2 comments

Comments

@msxfm
Copy link

msxfm commented Jul 7, 2014

Issue by jsamuel
Thursday Dec 22, 2011 at 18:48 GMT
Originally opened as RequestPolicy/requestpolicy#49


imported trac ticket
created: 2009-10-24 00:49:13
reporter: emk

Just a simple typo, but critical.
https://www.requestpolicy.com/dev/browser/src/modules/DomainUtil.jsm#L144
144 if (e.name == "NS_ERROR_HOST_IS_IP_ADDRESS ") {
Please trim an extra trailing space.

@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by jsamuel
Thursday Dec 22, 2011 at 18:48 GMT


imported trac comment
created: 2009-10-24 07:43:57
author: justin

Thanks for catching this. I've just introduced this bug recently, I believe, while fixing a bug in the same part of the code. I'm walking out the door right now to get on flight so can't fix it right now. In the mean time, I've pulled the 0.5.11 version's file from AMO so that it doesn't get reviewed/approved while I'm out of town for the weekend.

I fix this first thing next week and push 0.5.12.

Thanks again for finding this!

@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by jsamuel
Thursday Dec 22, 2011 at 18:48 GMT


imported trac comment
created: 2009-10-26 08:34:12
author: justin

Fixed in r299. Thanks again, emk.

@msxfm msxfm closed this as completed Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant