Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-forge, markdown-it-py dependencies are still mandatory #175

Closed
layday opened this issue Sep 19, 2023 · 3 comments
Closed

python-forge, markdown-it-py dependencies are still mandatory #175

layday opened this issue Sep 19, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@layday
Copy link
Contributor

layday commented Sep 19, 2023

python-forge and markdown-it-py are optional in Poetry's configuration but are not associated with an extra. The only way to mark a dependency as being optional in core metadata is by association with an extra, e.g. Requires-Dist: foo ; extra == "bar". The Poetry builder does not omit or raise for unlinked optional dependencies, but emits them without an extra marker, meaning that they are installed by default.

@layday layday added the bug Something isn't working label Sep 19, 2023
@JWCook JWCook added this to the v0.9 milestone Sep 19, 2023
@JWCook
Copy link
Member

JWCook commented Sep 19, 2023

Oh, I wasn't aware of that behavior. Thanks for letting me know.

@JWCook
Copy link
Member

JWCook commented Sep 20, 2023

Fixed in v0.9.1. I verified that only the expected dependencies are installed now:

aiohttp-client-cache==0.9.1
    itsdangerous==2.1.2
    url-normalize==1.4.3
        six==1.16.0
    aiohttp==3.8.5
        aiosignal==1.3.1
        async-timeout==4.0.3
        attrs==23.1.0
        charset-normalizer==3.2.0
        frozenlist==1.4.0
        idna==3.4
        multidict==6.0.4
        yarl==1.9.2

@layday
Copy link
Contributor Author

layday commented Sep 20, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants