Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional support for Cache-Control: max-age and no-store response headers #54

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Add optional support for Cache-Control: max-age and no-store response headers #54

merged 3 commits into from
Apr 14, 2021

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Apr 14, 2021 •
edited
Loading

Closes #30

Notes

  • Add support for Cache-Control: max-age
  • Add support for Cache-Control: no-store
  • Handle comma-separated lists of Cache-Control directives
  • Add cache_control option to CacheBackend to enable new behavior
  • As a side effect, this also adds support for setting expire_after=0 to disable saving responses to the cache.

@JWCook JWCook added the enhancement New feature or request label Apr 14, 2021
@JWCook JWCook added this to the v0.4 milestone Apr 14, 2021
@JWCook JWCook force-pushed the cache-control branch 3 times, most recently from bcf0656 to f6c0263 Compare April 14, 2021 20:41
@JWCook JWCook changed the title Add optional support for Cache-Control: max-age header Add optional support for Cache-Control: max-age and no-store response headers Apr 14, 2021
@JWCook JWCook marked this pull request as ready for review April 14, 2021 21:37
@JWCook JWCook merged commit 002ba29 into main Apr 14, 2021
JWCook added a commit that referenced this pull request Apr 14, 2021
@JWCook
Merge pull request #54 from JWCook/cache-control
069568e 
Add optional support for Cache-Control: max-age and no-store response headers
@JWCook JWCook deleted the cache-control branch April 14, 2021 21:40
This was referenced Apr 14, 2021
Closed
Closed
JWCook added a commit that referenced this pull request Apr 16, 2021
@JWCook
Merge pull request #54 from JWCook/cache-control
1b59a22 
Add optional support for Cache-Control: max-age and no-store response headers
JWCook added a commit that referenced this pull request May 17, 2021
@JWCook
Merge pull request #54 from JWCook/cache-control
3993932 
Add optional support for Cache-Control: max-age and no-store response headers
JWCook added a commit that referenced this pull request May 18, 2021
@JWCook
Merge pull request #54 from JWCook/cache-control
b19d8e8 
Add optional support for Cache-Control: max-age and no-store response headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Add option to use Cache-Control:max-age header to set expiration time
1 participant
@JWCook