Fixes error 400 responses from patched form boundary #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests_cache version 1.2.0 causes our server to respond with error 400 on multipart requests.
After some investigation, i tracked this down to PR #919:
With the older format i get a proper response (status 200):
FORM_BOUNDARY = '##requests-cache-form-boundary##'
With the new format i get error 400:
FORM_BOUNDARY = '==requests-cache-form-boundary=='
I'm not very experienced with requests, but to my understanding RFC2046 suggests "The boundary delimiter line is then defined as a line consisting entirely of two hyphen characters ("-", decimal value 45) [...]"
So, i tested replacing the "==" with hyphens "--" in the below formats:
FORM_BOUNDARY = '--requests-cache-form-boundary--'
FORM_BOUNDARY = '--requests-cache-form-boundary'
Both formats above seem to be accepted with no problems.
Unless i am missing something, I would propose to keep the 1st format, which seems more in line with the past forms.