Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming upload does not work #88

Open
prokopst opened this issue Dec 16, 2016 · 4 comments
Open

Streaming upload does not work #88

prokopst opened this issue Dec 16, 2016 · 4 comments

Comments

@prokopst
Copy link

It seems that streaming upload does not work, most likely because the file is reset only once. This is related to #87, because the data is sent three times.

For example code similar to this snippet does not work, it's always stuck:

session = Session(auth=HttpNtlmAuth(username, password))
with open("blabla.txt") as file:
    session.put(url="https://webdav-server/", data=file, timeout=10)

pip freeze says:

requests==2.11.1
requests-ntlm==1.0.0
@Lukasa
Copy link
Member

Lukasa commented Dec 16, 2016

Yeah, this looks like a bug. I think we'd need to use some of the code in the newer versions of Requests for seeking back the body if possible.

I'm on holiday for the rest of the year which means that I won't be able to get to this until next year, but I am happy to review patches if anyone feels like tackling this.

@nateprewitt
Copy link

It looks like this would be a pretty simple fix with rewind_body from 2.12.4. Are we alright requiring the latest version of requests being the minimum version for this module? If so, I can look into integrating it.

@ofek
Copy link

ofek commented Jun 26, 2018

Has this been fixed?

@kamikaze
Copy link

kamikaze commented Jul 3, 2018

it seems that this project is abandonned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants