Stop bundling urllib3, just add it to install_requires

[sontek]

No description provided.

[sigmavirus24]

We have discussed this issue with users several times in the past. A search of the issues that are closed would show that. Our opinion has not changed, nor has our reasoning. By vendoring urllib3 we have a very specific version that we have tested against that may include unreleased bug fixes and does not put pressure on @shazow. It also allows us to checkout a specific version of the repository and just work on it with what existed at the time. It's reliable and it will be how we work for the foreseeable future. I'll leave this open until @Lukasa can make his way around to it, but I'm strongly in favor of closing this.

[sontek]

Fixed by https://github.com/kennethreitz/requests/pull/1812

[sontek]

@sigmavirus24 The big problem is that distros remove the bundled version anyways, making conflicts when you want to handle exceptions / use urllib3 directly, since requests is using a different version than everything else.

[sontek]

For example, if you look at the patch Fedora keeps around for requests:

http://pkgs.fedoraproject.org/cgit/python-requests.git/commit/?id=2f898f274c560a0fb5ac48719a9529f68688fb7a

I think doing a requires>= <= would also be acceptable practice, allowing you to pin a range of versions you know are working with requests.

[sigmavirus24]

Since #1812 has been closed, I feel it's fair to close this and end the discussion. We've discussed this publicly before and we have discussed it with many of the distro package maintainers who package requests for you and everyone else. Our stance has also always been to use PyPI and not the distro packages because they remove the vendored dependencies.