ISO-8859-1 fallback for reason decoding #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| reason = self.reason.decode('utf-8') | ||
| except UnicodeDecodeError: | ||
| reason = self.reason.decode('iso-8859-1') |
There was a problem hiding this comment.
Can we add comments to the start of this block explaining why we're doing this?
nateprewitt
force-pushed
the
3538_fallback_to_ISO_8591_1
branch
from
b5205af
to
2e1086f
Compare
|
@sigmavirus24 are you happy with this? |
|
Yep! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposed solution to #3538 by falling back from Unicode to ISO-8859-1 for raw reason decoding.
This is a relatively trivial fix, and I wasn't sure if you wanted to waste bandwidth fixing, @mitsuhiko. I had a brief chat with @Lukasa who said to toss this up, but I'll gladly drop it in favor of #3538, if you had plans to update.