Allow urllib3 1.23

[michael-k]

Changelog: https://github.com/urllib3/urllib3/blob/1.23/CHANGES.rst#123-2018-06-04

[codecov-io]

Codecov Report

Merging #4669 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4669   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files          15       15           
  Lines        1564     1564           
=======================================
  Hits         1042     1042           
  Misses        522      522

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fd4c8...ac944b7. Read the comment docs.

[sethmlarson]

LGTM :)

[nateprewitt]

Hi @michael-k, thanks for the initiative here. We’ve historically done this bump when we release a new major version of Requests as part of our release proceess. That is typically a week or two after the urllib3 release so there’s time for any immediate bugs to surface.

Since we’re no longer vendoring, we can merge this now, but it will probably be easier in the future to do all the release actions at once. Thanks again!

[bar]

Can you please bump requests with this fix so we can fix the current version conflicts?

There are a lot of other libs out there that don't cap urllib3 meaning they are failing due to this cap

[nateprewitt]

Hi @bar, I’ve just commented on a PR to address this. We usually won’t modify this until we are ready for a release. It shouldn’t break anything, but simply emits a warning.

We’ll have a release out in the next week or two once urllib3’s new version has had a chance to settle. I’ll try to get master a bit cleaner this evening.

[lilydjwg]

Lots of warning emails send me here. I'm going to edit the local code now because I don't like the coming thousands of emails.