Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve message format on commit #27

Closed
biels opened this issue Feb 14, 2017 · 3 comments
Closed

[Enhancement] Improve message format on commit #27

biels opened this issue Feb 14, 2017 · 3 comments

Comments

@biels
Copy link

biels commented Feb 14, 2017

You should look at the bot @githubbot and see how it displays commit and issue messages.
image
I am using Integram with Bitbucket. The main problem is that if you provide a direct url, telegram renders it along with a giant profile picture on mobile devices. This quickly floods development groups.

I think implementing an output format like the one above shouldn't be difficult at all. If you point me in the right direction I could even make a pull request for you. Thanks!

Edit: Took a look at the code, the changes should be made around here: https://github.com/Requilence/integram/blob/master/services/bitbucket/webhook.go#L340

@requilence
Copy link
Owner

Hi! This was not a bug but feature 😀 But I agree with you. The commit messages should be more compact. I fixed that @f8a992dc48002089b4533175c9e1cde2610c0621 and deployed to production

@biels
Copy link
Author

biels commented Feb 15, 2017

Wow! Tanks for the quick fix! Tested it and looks way better.
For now, closing. If I see something else or have another idea I will create another issue for that.

@biels biels closed this as completed Feb 15, 2017
@biels biels reopened this Jan 25, 2018
@biels
Copy link
Author

biels commented Jan 25, 2018

This issue is not fixed yet for more than one commit in the same push. The message gets really messy. Could the design be like the one posted in the first issue?
[Hammer emoji] [n] new commit[s] to [Repo]:[Branch]:
[commit 1 hash with link]: [Message] by [User name]
[commit 2 hash with link]: [Message] by [User name]
[commit n hash with link]: [Message] by [User name]
And if the message starts to get past a certain length then start doing ellipsis on commit messages and finally if there are more than n commits (for example 6) add "and n more" with a link to commits page.

It think it's a great way to improve integram with very little effort!

@biels biels closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants