Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab bot wrong message on merge request approval #84

Open
ave-satan opened this issue Aug 13, 2019 · 5 comments
Open

GitLab bot wrong message on merge request approval #84

ave-satan opened this issue Aug 13, 2019 · 5 comments

Comments

@ave-satan
Copy link

When I approve a merge request the bot says it had been opened by me instead of approved

@ave-satan
Copy link
Author

Revoking approval works the same way

@requilence
Copy link
Owner

@ave-satan thanks for reporting! If you have experience with Go you can provide the PR, I will be happy to merge it. Otherwise, I will be able to handle this later this week

@hieultan
Copy link

I got the same issues

@trongthanh
Copy link

trongthanh commented Dec 26, 2019

Bump this issue. Please take a look at this soon.

I don't know any Go, but taking a quick look at this Gitlab adapter, I guess, approved action is not handled, so it falls back to 'open'.

@msergein
Copy link

please fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants