Fixes requirejs/requirejs#911, do not trigger callbacks if errbacks c…

…alled in node
requirejs · Jan 6, 2014 · 1235f38 · 1235f38
1 parent 729f6ec
commit 1235f38
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/build/jslib/node.js b/build/jslib/node.js
@@ -159,7 +159,7 @@
                     err.originalError = e;
                     err.moduleName = originalName;
                     err.requireModules = [moduleName];
-                    return context.onError(err);
+                    throw err;
                 }
             });
         }

diff --git a/tests/all.js b/tests/all.js
@@ -44,6 +44,17 @@ require({
     );
     doh.run();
 
+    define('testError', function () {
+        requirejs(['nonExistingModule'], function () {
+            console.log('BIG TIME FAIL');
+        }, function (err) {
+            console.log('OK');
+        });
+    });
+
+    require(['testError']);
+
+
     //Print out the test summary.
     doh.run();
 });