Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.js 1.0.3 always passes truthy to uglify for strict_semicolons option #69

Closed
ArturDorochowicz opened this issue Dec 28, 2011 · 4 comments
Milestone

Comments

@ArturDorochowicz
Copy link
Contributor

Changes in #67 (7650beb#L1L265) introduced an issue where a truthy value (config object) is always passed to uglify.js for strict_semicolons option. This makes it impossible to control that option and is too strict - the default value is false.

@busticated
Copy link

+1

After a fair amount of time digging into why my known-good projects were all now throwing "Cannot uglify file... Unexpected token" errors, it seems this is the root cause.

@jrburke
Copy link
Member

jrburke commented Jan 3, 2012

Thanks for finding this. I'll work on doing a 1.0.4 release in the next few days to get this fixed.

@busticated
Copy link

thanks James!

@jrburke jrburke closed this as completed in 4e720e2 Jan 4, 2012
@jrburke
Copy link
Member

jrburke commented Jan 4, 2012

This is fixed now in r-edge.js if you want to try the fix, and it will be part of a 1.0.4 release that goes out this week. Sorry I let this one go so long without a fix. I just goofed the original change in #67 when I was translating/checking the API calls on the uglifyjs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants