Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load shim from package name if no shim for moduleName. #331

Merged
merged 3 commits into from Jan 9, 2013

Conversation

maxpeterson
Copy link
Contributor

This is a possible fix for #310

The idea is to try and get the the shim for a module based on the package name in the case that the module name includes packageConfig.main.

In the case that you have a package

  {
      "name": "backbone",
      "location": "jam/backbone",
      "main": "backbone.js"
  }

then it would try and get shim['backbone'] if there was no shim['backbone/backbone']

jrburke added a commit that referenced this pull request Jan 9, 2013
jrburke added a commit that referenced this pull request Jan 9, 2013
@jrburke jrburke merged commit a609335 into requirejs:master Jan 9, 2013
@jrburke
Copy link
Member

jrburke commented Jan 9, 2013

Thank you, merged. You can try latest master snapshot to confirm the fix:
https://raw.github.com/jrburke/r.js/master/dist/r.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants