Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license comment "doubling" issue #965

Merged
merged 2 commits into from Jul 30, 2017
Merged

Fix license comment "doubling" issue #965

merged 2 commits into from Jul 30, 2017

Conversation

elliot-nelson
Copy link
Contributor

GOAL

Bugfix for #964, which causes preserved license comments to be written to the built source file twice, resulting in an incorrect source map.

CHANGES

  • Add a test that runs uglify with preserveLicenseComments and generateSourceMaps on.
  • One-line fix in build/jslib/optimize.js.

@jsf-clabot
Copy link

jsf-clabot commented Jul 30, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@jrburke jrburke added this to the 2.3.5 milestone Jul 30, 2017
@jrburke jrburke merged commit a5752b0 into requirejs:master Jul 30, 2017
@jrburke
Copy link
Member

jrburke commented Jul 30, 2017

Thanks for the great PR with a test! Merged, I will commit one small cleanup to remove creating a local preamble variable, but this is great, thanks. Marked for next release, 2.3.5.

jrburke added a commit that referenced this pull request Jul 30, 2017
@jrburke
Relates to #965, remove local preamble var no longer used
8cba8b2
@jrburke jrburke mentioned this pull request Aug 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elliot-nelson @jsf-clabot @jrburke