request: fix pickup location update #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-fix-pickup-location-update
branch
2 times, most recently
from
115e203
to
e4e95b2
Compare
benerken
approved these changes
Apr 28, 2020
sebdeleze
approved these changes
Apr 28, 2020
...n/src/app/record/detail-view/item-detail-view/item-transaction/item-transaction.component.ts
Outdated
Show resolved
Hide resolved
...n/src/app/record/detail-view/item-detail-view/item-transaction/item-transaction.component.ts
Outdated
Show resolved
Hide resolved
...n/src/app/record/detail-view/item-detail-view/item-transaction/item-transaction.component.ts
Outdated
Show resolved
Hide resolved
zannkukai
approved these changes
Apr 28, 2020
* Fixes pickup location update on item detail view using Chrome. * Changes cancel button design according to UX charter. * Adds a message on mouse hover over cancel button and no-editable pickup location. * Closes rero/rero-ils#960. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-fix-pickup-location-update
branch
from
e4e95b2
to
d63f0e1
Compare
benerken
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To fix pickup location update on item detail view using Chrome.
To close rero/rero-ils#960.
How to test?
Code review check list